From bd597fbc6415cc62175e9d2c4307aa51472c2409 Mon Sep 17 00:00:00 2001 From: siujamo Date: Thu, 12 Mar 2026 14:44:59 +0800 Subject: [PATCH] refactor: extract build cookie --- .../onixbyte/helix/service/AuthService.java | 38 +++++++++---------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/main/java/com/onixbyte/helix/service/AuthService.java b/src/main/java/com/onixbyte/helix/service/AuthService.java index 37408bc..82ea596 100644 --- a/src/main/java/com/onixbyte/helix/service/AuthService.java +++ b/src/main/java/com/onixbyte/helix/service/AuthService.java @@ -95,29 +95,29 @@ public class AuthService { .orElse(false); } - public ResponseCookie buildCookie(String cookieName, String token) { - var cookieBuilder = ResponseCookie.from(cookieName, token) - .maxAge(securityManager.getTokenValidDuration()) - .secure(true) - .path("/"); - - var applicationMode = applicationManager.getApplicationMode(); - switch (applicationMode) { - case PRODUCTION -> cookieBuilder.httpOnly(true); - case DEVELOPMENT -> cookieBuilder.sameSite("NONE"); - case null, default -> { - } - } - - return cookieBuilder.build(); + public ResponseCookie buildCookie(String cookieName, String value) { + return buildCookieInternal(cookieName, value, securityManager.getTokenValidDuration()) + .build(); } - public ResponseCookie buildCookie(String cookieName, String token, Duration validDuration) { - var cookieBuilder = ResponseCookie.from(cookieName, token) - .httpOnly(true) + public ResponseCookie buildCookie(String cookieName, String value, Duration validDuration) { + return buildCookieInternal(cookieName, value, validDuration) + .build(); + } + + protected ResponseCookie.ResponseCookieBuilder buildCookieInternal(String cookieName, String value, Duration validDuration) { + var applicationMode = applicationManager.getApplicationMode(); + + var cookieBuilder = ResponseCookie.from(cookieName, value) + .maxAge(securityManager.getTokenValidDuration()) + .secure(true) .maxAge(validDuration) .path("/"); - return cookieBuilder.build(); + return switch (applicationMode) { + case PRODUCTION -> cookieBuilder.httpOnly(true); + case DEVELOPMENT -> cookieBuilder.sameSite("NONE"); + case null -> cookieBuilder; + }; } }