From 8b343af4e815d3d96685cdac2b514314a954c7ab Mon Sep 17 00:00:00 2001 From: siujamo Date: Mon, 23 Mar 2026 15:45:11 +0800 Subject: [PATCH] refactor: remove unused logger imports and related fields from manager and controller classes --- .../java/com/onixbyte/helix/controller/AuthController.java | 3 --- .../onixbyte/helix/domain/web/request/EditRoleRequest.java | 1 - src/main/java/com/onixbyte/helix/manager/AssetManager.java | 5 +---- .../java/com/onixbyte/helix/manager/AuthorityManager.java | 3 --- .../java/com/onixbyte/helix/manager/DepartmentManager.java | 5 +---- src/main/java/com/onixbyte/helix/manager/MenuManager.java | 4 +--- .../java/com/onixbyte/helix/manager/PositionManager.java | 5 +---- .../com/onixbyte/helix/manager/RoleAuthorityManager.java | 5 +---- src/main/java/com/onixbyte/helix/manager/RoleManager.java | 5 +---- .../java/com/onixbyte/helix/manager/UserRoleManager.java | 6 +----- .../com/onixbyte/helix/repository/AuthorityRepository.java | 1 - src/main/java/com/onixbyte/helix/service/MenuService.java | 4 +--- 12 files changed, 8 insertions(+), 39 deletions(-) diff --git a/src/main/java/com/onixbyte/helix/controller/AuthController.java b/src/main/java/com/onixbyte/helix/controller/AuthController.java index 1bef319..2b193d4 100644 --- a/src/main/java/com/onixbyte/helix/controller/AuthController.java +++ b/src/main/java/com/onixbyte/helix/controller/AuthController.java @@ -6,8 +6,6 @@ import com.onixbyte.helix.service.AuthService; import com.onixbyte.helix.service.TokenService; import com.onixbyte.helix.service.UserService; import com.onixbyte.helix.shared.TokenConstant; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.http.HttpHeaders; import org.springframework.http.HttpStatus; @@ -27,7 +25,6 @@ import java.time.Duration; @RequestMapping("/auth") public class AuthController { - private static final Logger log = LoggerFactory.getLogger(AuthController.class); private final AuthService authService; private final TokenService tokenService; private final UserService userService; diff --git a/src/main/java/com/onixbyte/helix/domain/web/request/EditRoleRequest.java b/src/main/java/com/onixbyte/helix/domain/web/request/EditRoleRequest.java index 9392181..293311e 100644 --- a/src/main/java/com/onixbyte/helix/domain/web/request/EditRoleRequest.java +++ b/src/main/java/com/onixbyte/helix/domain/web/request/EditRoleRequest.java @@ -1,6 +1,5 @@ package com.onixbyte.helix.domain.web.request; -import jakarta.validation.constraints.NotBlank; import jakarta.validation.constraints.NotNull; import jakarta.validation.constraints.Pattern; diff --git a/src/main/java/com/onixbyte/helix/manager/AssetManager.java b/src/main/java/com/onixbyte/helix/manager/AssetManager.java index d899fd8..c4b89ec 100644 --- a/src/main/java/com/onixbyte/helix/manager/AssetManager.java +++ b/src/main/java/com/onixbyte/helix/manager/AssetManager.java @@ -2,7 +2,6 @@ package com.onixbyte.helix.manager; import com.onixbyte.helix.shared.CacheName; import com.onixbyte.helix.domain.entity.Asset; -import com.onixbyte.helix.mapper.AssetMapper; import com.onixbyte.helix.repository.AssetRepository; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.cache.annotation.CacheEvict; @@ -13,12 +12,10 @@ import org.springframework.stereotype.Component; @Component public class AssetManager { - private final AssetMapper assetMapper; private final AssetRepository assetRepository; @Autowired - public AssetManager(AssetMapper assetMapper, AssetRepository assetRepository) { - this.assetMapper = assetMapper; + public AssetManager(AssetRepository assetRepository) { this.assetRepository = assetRepository; } diff --git a/src/main/java/com/onixbyte/helix/manager/AuthorityManager.java b/src/main/java/com/onixbyte/helix/manager/AuthorityManager.java index e52cd8a..975a647 100644 --- a/src/main/java/com/onixbyte/helix/manager/AuthorityManager.java +++ b/src/main/java/com/onixbyte/helix/manager/AuthorityManager.java @@ -8,8 +8,6 @@ import com.onixbyte.helix.exception.BizException; import com.onixbyte.helix.mapper.AuthorityMapper; import com.onixbyte.helix.repository.AuthorityRepository; import com.onixbyte.helix.shared.CacheName; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.cache.annotation.Cacheable; import org.springframework.data.domain.Example; @@ -25,7 +23,6 @@ import java.util.Optional; @Component public class AuthorityManager { - private static final Logger log = LoggerFactory.getLogger(AuthorityManager.class); private final AuthorityMapper authorityMapper; private final AuthorityRepository authorityRepository; diff --git a/src/main/java/com/onixbyte/helix/manager/DepartmentManager.java b/src/main/java/com/onixbyte/helix/manager/DepartmentManager.java index db9524e..25fbe50 100644 --- a/src/main/java/com/onixbyte/helix/manager/DepartmentManager.java +++ b/src/main/java/com/onixbyte/helix/manager/DepartmentManager.java @@ -1,7 +1,6 @@ package com.onixbyte.helix.manager; import com.onixbyte.helix.domain.entity.Department; -import com.onixbyte.helix.mapper.DepartmentMapper; import com.onixbyte.helix.repository.DepartmentRepository; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.data.domain.Page; @@ -13,12 +12,10 @@ import java.util.Optional; @Component public class DepartmentManager { - private final DepartmentMapper departmentMapper; private final DepartmentRepository departmentRepository; @Autowired - public DepartmentManager(DepartmentMapper departmentMapper, DepartmentRepository departmentRepository) { - this.departmentMapper = departmentMapper; + public DepartmentManager(DepartmentRepository departmentRepository) { this.departmentRepository = departmentRepository; } diff --git a/src/main/java/com/onixbyte/helix/manager/MenuManager.java b/src/main/java/com/onixbyte/helix/manager/MenuManager.java index b4d491b..dcca73d 100644 --- a/src/main/java/com/onixbyte/helix/manager/MenuManager.java +++ b/src/main/java/com/onixbyte/helix/manager/MenuManager.java @@ -2,8 +2,6 @@ package com.onixbyte.helix.manager; import com.onixbyte.helix.domain.entity.Menu; import com.onixbyte.helix.mapper.MenuMapper; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Component; @@ -11,7 +9,7 @@ import java.util.List; @Component public class MenuManager { - private static final Logger log = LoggerFactory.getLogger(MenuManager.class); + private final MenuMapper menuMapper; @Autowired diff --git a/src/main/java/com/onixbyte/helix/manager/PositionManager.java b/src/main/java/com/onixbyte/helix/manager/PositionManager.java index c3a0349..ed8f23f 100644 --- a/src/main/java/com/onixbyte/helix/manager/PositionManager.java +++ b/src/main/java/com/onixbyte/helix/manager/PositionManager.java @@ -1,7 +1,6 @@ package com.onixbyte.helix.manager; import com.onixbyte.helix.domain.entity.Position; -import com.onixbyte.helix.mapper.PositionMapper; import com.onixbyte.helix.repository.PositionRepository; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.data.domain.Page; @@ -11,12 +10,10 @@ import org.springframework.stereotype.Component; @Component public class PositionManager { - private final PositionMapper positionMapper; private final PositionRepository positionRepository; @Autowired - public PositionManager(PositionMapper positionMapper, PositionRepository positionRepository) { - this.positionMapper = positionMapper; + public PositionManager(PositionRepository positionRepository) { this.positionRepository = positionRepository; } diff --git a/src/main/java/com/onixbyte/helix/manager/RoleAuthorityManager.java b/src/main/java/com/onixbyte/helix/manager/RoleAuthorityManager.java index d29e80f..300ef05 100644 --- a/src/main/java/com/onixbyte/helix/manager/RoleAuthorityManager.java +++ b/src/main/java/com/onixbyte/helix/manager/RoleAuthorityManager.java @@ -1,7 +1,6 @@ package com.onixbyte.helix.manager; import com.onixbyte.helix.mapper.RoleAuthorityMapper; -import com.onixbyte.helix.repository.RoleAuthorityRepository; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.stereotype.Component; @@ -10,11 +9,9 @@ import org.springframework.stereotype.Component; public class RoleAuthorityManager { private static final Logger log = LoggerFactory.getLogger(RoleAuthorityManager.class); - private final RoleAuthorityRepository roleAuthorityRepository; private final RoleAuthorityMapper roleAuthorityMapper; - public RoleAuthorityManager(RoleAuthorityRepository roleAuthorityRepository, RoleAuthorityMapper roleAuthorityMapper) { - this.roleAuthorityRepository = roleAuthorityRepository; + public RoleAuthorityManager(RoleAuthorityMapper roleAuthorityMapper) { this.roleAuthorityMapper = roleAuthorityMapper; } diff --git a/src/main/java/com/onixbyte/helix/manager/RoleManager.java b/src/main/java/com/onixbyte/helix/manager/RoleManager.java index 685a794..926549d 100644 --- a/src/main/java/com/onixbyte/helix/manager/RoleManager.java +++ b/src/main/java/com/onixbyte/helix/manager/RoleManager.java @@ -3,7 +3,6 @@ package com.onixbyte.helix.manager; import com.onixbyte.helix.domain.database.query.wrapper.QueryRoleWrapper; import com.onixbyte.helix.domain.entity.Role; import com.onixbyte.helix.exception.BizException; -import com.onixbyte.helix.mapper.RoleAuthorityMapper; import com.onixbyte.helix.mapper.RoleMapper; import com.onixbyte.helix.repository.RoleRepository; import org.springframework.beans.factory.annotation.Autowired; @@ -20,13 +19,11 @@ public class RoleManager { private final RoleMapper roleMapper; private final RoleRepository roleRepository; - private final RoleAuthorityMapper roleAuthorityMapper; @Autowired - public RoleManager(RoleMapper roleMapper, RoleRepository roleRepository, RoleAuthorityMapper roleAuthorityMapper) { + public RoleManager(RoleMapper roleMapper, RoleRepository roleRepository) { this.roleMapper = roleMapper; this.roleRepository = roleRepository; - this.roleAuthorityMapper = roleAuthorityMapper; } public void validateRoles(List roleIds) { diff --git a/src/main/java/com/onixbyte/helix/manager/UserRoleManager.java b/src/main/java/com/onixbyte/helix/manager/UserRoleManager.java index 0350bff..8a4ba8a 100644 --- a/src/main/java/com/onixbyte/helix/manager/UserRoleManager.java +++ b/src/main/java/com/onixbyte/helix/manager/UserRoleManager.java @@ -1,8 +1,6 @@ package com.onixbyte.helix.manager; import com.onixbyte.helix.domain.entity.UserRole; -import com.onixbyte.helix.domain.entity.embeddable.UserRoleId; -import com.onixbyte.helix.mapper.UserRoleMapper; import com.onixbyte.helix.repository.UserRoleRepository; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -15,12 +13,10 @@ import java.util.List; public class UserRoleManager { private static final Logger log = LoggerFactory.getLogger(UserRoleManager.class); - private final UserRoleMapper userRoleMapper; private final UserRoleRepository userRoleRepository; @Autowired - public UserRoleManager(UserRoleMapper userRoleMapper, UserRoleRepository userRoleRepository) { - this.userRoleMapper = userRoleMapper; + public UserRoleManager(UserRoleRepository userRoleRepository) { this.userRoleRepository = userRoleRepository; } diff --git a/src/main/java/com/onixbyte/helix/repository/AuthorityRepository.java b/src/main/java/com/onixbyte/helix/repository/AuthorityRepository.java index ce52bb9..4007991 100644 --- a/src/main/java/com/onixbyte/helix/repository/AuthorityRepository.java +++ b/src/main/java/com/onixbyte/helix/repository/AuthorityRepository.java @@ -3,7 +3,6 @@ package com.onixbyte.helix.repository; import com.onixbyte.helix.domain.entity.Authority; import org.springframework.data.jpa.repository.JpaRepository; import org.springframework.data.jpa.repository.Query; -import org.springframework.data.repository.query.Param; import org.springframework.stereotype.Repository; @Repository diff --git a/src/main/java/com/onixbyte/helix/service/MenuService.java b/src/main/java/com/onixbyte/helix/service/MenuService.java index ad5a57f..cba7625 100644 --- a/src/main/java/com/onixbyte/helix/service/MenuService.java +++ b/src/main/java/com/onixbyte/helix/service/MenuService.java @@ -5,8 +5,6 @@ import com.onixbyte.helix.domain.common.TreeNode; import com.onixbyte.helix.manager.MenuManager; import com.onixbyte.helix.utils.SecurityUtil; import com.onixbyte.helix.utils.TreeUtil; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Service; @@ -14,7 +12,7 @@ import java.util.List; @Service public class MenuService { - private static final Logger log = LoggerFactory.getLogger(MenuService.class); + private final MenuManager menuManager; @Autowired